alessandrobenedetti commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479357302
Ok, let me rephrase my question then: Let's assume: - we don't care why that class was originally created and its JavaDocs comments - we don't intend to modify it Quoting @dsmiley "Why is it important that BoostAttribute's usage be constrained to only MultiTermQuery?" (from the code is just containing a float payload). What makes the BoostAttribute different from the org.apache.lucene.analysis.tokenattributes.PayloadAttribute for example? (aside from the different types of payload BytesRef vs float). Let's just give a constructive explanation if you know, rather than citing again that JavaDoc :) N.B. I am not a strenuous defender of using that class, to be clear, I want to do best in terms of readability and quality for the project, I just want my review to improve the work of the original contributors of this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
