alessandrobenedetti commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1468487080
> > I'll leave the BoostAttribute discussion for another time as I don't have access to the code right now, but javaDocs or not, it seems extremely suspicious to have a public class that shouldn't be used, it smells bad practice, quite frankly. > > The problem is how attributes work internally. that's why fuzzy's internal boostattribute is public. It is really important that this only be used by fuzzyquery, it is only for multitermquery. That's why it is documented as such. >>I am not going to leave the discussion for another time. This needs to be fixed. Hi @rmuir, first of all, I deeply appreciate the time you are taking to help us on this issue, thank you for that. When I said "'ll leave the BoostAttribute discussion for another time" I meant today (I was on holiday last week and I had the chance to look at the code only today with @dantuzi and @ilariapet . I appreciate the javaDoc comments, but as also @dsmiley mentioned, I would like to understand practical reasons to avoid the use of the BoostAttribute in other areas. It seems to me just a simple wrapper of a float value. Having a JavaDoc comment to restrict the usage of a public class is not ideal, but if you can elaborate we are more than happy to improve the contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
