alessandrobenedetti commented on PR #12169: URL: https://github.com/apache/lucene/pull/12169#issuecomment-1479386226
@rmuir bear in mind a veto should be motivated and I have seen honestly zero practical motivation so far. Given that, I definitely don't have time for sterile discussions and this has reached the threshold for what I consider long and sterile enough. I suggest we remove the boost entirely, so this becomes a regular synonym token filter (which simply takes synomyms from somewhere else). The boost was really just a nice addition, not the main core of the contribution. The (optional?) boost will be introduced in a separate pull request. If the community believes it's worth to duplicate the BoostAttribute with a QueryBoostAttribute we'll do it in that separate request (thanks @romseygeek for the suggestion). Thanks @msokolov for your detailed review, all good stuff, @dantuzi and Ilaria will take care of fixing stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
