nknize commented on code in PR #11753:
URL: https://github.com/apache/lucene/pull/11753#discussion_r1008219749
##########
lucene/core/src/java/org/apache/lucene/document/XYShape.java:
##########
@@ -269,4 +269,14 @@ public static Query newGeometryQuery(
}
return new XYShapeQuery(field, queryRelation, xyGeometries);
}
+
+ /**
+ * Factory method for creating the {@link XYShapeDocValues}
+ *
+ * @param bytesRef {@link BytesRef}
+ * @return {@link XYShapeDocValues}
+ */
+ public static XYShapeDocValues buildXYShapeDocValues(BytesRef bytesRef) {
Review Comment:
```suggestion
public static XYShapeDocValues createXYShapeDocValues(BytesRef bytesRef) {
```
##########
lucene/core/src/java/org/apache/lucene/document/LatLonShape.java:
##########
@@ -341,6 +341,16 @@ public static Query newGeometryQuery(
}
}
+ /**
+ * Factory method for creating the {@link LatLonShapeDocValues}
+ *
+ * @param bytesRef {@link BytesRef}
+ * @return {@link LatLonShapeDocValues}
+ */
+ public static LatLonShapeDocValues buildLatLonShapeDocValues(BytesRef
bytesRef) {
Review Comment:
Let's go ahead and make this consistent w/ all of the other factory methods.
```suggestion
public static LatLonShapeDocValues createLatLonShapeDocValues(BytesRef
bytesRef) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
