nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1295061435
If we can't think of anything quickly I think a good compromise would be to merge this long running PR so @navneet1v can use the field until we figure out if there even needs to be a separation of the binary doc value / bkd indexable field factory methods? I think the preference you raise of separating them is logical and reasonable, but we already have a single non-instantiable Factory Class and I don't know if there is a need for another one just to separate docvalues and bkd factory methods. We could achieve the same by adding inner static classes `LatLonShape.DocValueFactory` and `XYShape.DocValueFactory`, or creating separate factory classes in the same manner. Either way I think it's all just re-arranging deck chairs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
