iverase commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1295082525
I have a similar discussion not long time ago. At the moment, once you create a ShapeDocValues, you don't know if is geo or cartesian because the specific implementations are hidden from the user. I think this is not the right approach as they are not the same object with two different implementations but two different objects with similar behaviour. My opinion is that you should expose those concrete classes and the methods #createDocValuesField should return concrete implementations, that will allow you later on: 1) add methods that only make sense on geo / cartesian, e.g #distanceToEquator() in geo 2) Create methods that only make sense on geo / cartesian, e.g #computeDistanceToEquator(LatLonShapeDocValue) I just gave my opinion and thing are far away of what I think is best, maybe unnecessary for you. Feel free to push it, I am not blocking this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
