nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1294930300
> ... and make the constructor private. It makes no-sense to have them in LatLonShape / XYShape. The ctor is already protected. It does make sense in that LatLonShape and XYShape are already factory classes that provide the factory methods to create the fields, field values, and queries. So the discussion is over preference on where to access the doc value factory method for the public facing API. I like/prefer the consistency in having it with all of the other factory methods because it puts the javadocs and methods in one place. Either way we need the public factory method and where it lives can change so I don't think the bikeshedding should hold up getting the method in and moving it later if there's that strong of opposition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
