nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1295095640
> once you create a ShapeDocValues, you don't know if is geo or cartesian because the specific implementations are hidden from the user I'm not following what you mean by this. The abstract [`ShapeDocValues` class is package private](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java#L51), the concrete [LatLonShapeDocValues](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/LatLonShapeDocValues.java#L34) and [XYShapeDocValues](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/XYShapeDocValues.java) implementations are public. The factory methods are / will be public (this PR) and they return the concrete Cartesian or Geographic instance. I'm not sure how that obfuscates anything from the user? My understanding of the preferred change to this PR was just the location of the factory methods, am I misunderstanding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
