iverase commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1295112835
I lost myself here: First: > I see what you're saying, and I really like that idea of separating DocValues and BKD factory methods to their own factory classes. Except currently [LatLonShapeDocValuesQuery](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/LatLonShapeDocValuesQuery.java#L30) and [XYShapeDocValuesQuery](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/XYShapeDocValuesQuery.java#L29) are not public and so their factory methods [already live inside LatLonShape](https://github.com/apache/lucene/blob/5c7edd7f387032485a9fd49508b6c028bff688f0/lucene/core/src/java/org/apache/lucene/document/LatLonShape.java#L262) and [XYShape](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/XYShape.java#L213) factory class, respectively, as does the [createDocValuesField factory methods](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/LatLonShape.jav a#L89). The [javadocs](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/LatLonShape.java#L48) have all of these factory methods listed as their respective createIndexableFIelds vs createDocValuesField. I thought you were speaking about fields not queries. That is the kind of mess I am trying to avoid, DocValuesQueries that can only be accessed from LatLonShape but not from the actual field that is using them. Anyway as I said feel free to push it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
