iverase commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1294716060
I will say it again, please move the factory methods to the docvalues classes and make the constructor private. It makes no-sense to have them in LatLonShape / XYShape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
