rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2064166754
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##########
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADATA, EMPTY_OBJECT),
Variant.of(TEST_METADATA, TEST_OBJECT),
Variant.of(TEST_METADATA, SIMILAR_OBJECT),
+ Variant.of(TEST_METADATA, ARRAY_IN_OBJECT),
+ Variant.of(EMPTY_METADATA, EMPTY_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_NESTED_ARRAY),
+ Variant.of(TEST_METADATA, TEST_OBJECT_IN_ARRAY),
Review Comment:
Thanks, @XBaith. I think that we need to include the changes to
`ParquetSchemaProducer` here. Otherwise the changes aren't exercised and we
need those changes to properly test this PR.
Would it be alright with you if your changes were picked into this PR and
you were listed as a co-author?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
