rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062733967
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##########
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADATA, EMPTY_OBJECT),
Variant.of(TEST_METADATA, TEST_OBJECT),
Variant.of(TEST_METADATA, SIMILAR_OBJECT),
+ Variant.of(TEST_METADATA, ARRAY_IN_OBJECT),
+ Variant.of(EMPTY_METADATA, EMPTY_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_NESTED_ARRAY),
+ Variant.of(TEST_METADATA, TEST_OBJECT_IN_ARRAY),
Review Comment:
Thinking about this a little more, I think you'll probably want at least one
test where the array is shredded, but values are not (there is no consistent
type for elements). Then the mixed test will test whether existing shredding
works for arrays with partial shredding.
Here's what I'm thinking for test cases:
* An array of `"string"`, `"iceberg"`
* An array of `"string"`, `"iceberg"`, `34`
* An array of objects with a consistent schema that is the shredding schema
* An array of objects with the previous case's schema, along with numbers
and strings
* An array of arrays like you have, but with a consistent inner array
element type
* An object with arrays
The idea is to use the schemas produced from one test (like list<string>) to
test other cases in the mixed test (like list<string or int>).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
