rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2061126632
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##########
@@ -98,6 +99,26 @@ static ParquetValueWriter<VariantValue> objects(
builder.build());
}
+ public static ParquetValueWriter<?> array(
+ int valueDefinitionLevel,
+ ParquetValueWriter<?> valueWriter,
+ int typedDefinitionLevel,
+ int repeatedDefinitionLevel,
+ int repeatedRepetitionLevel,
+ ParquetValueWriter<?> elementWriter) {
+ ArrayWriter typedWriter =
+ new ArrayWriter(
Review Comment:
Like with the read path, should this construct the value writer and the
array writer separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
