XBaith commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2063309591
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##########
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADATA, EMPTY_OBJECT),
Variant.of(TEST_METADATA, TEST_OBJECT),
Variant.of(TEST_METADATA, SIMILAR_OBJECT),
+ Variant.of(TEST_METADATA, ARRAY_IN_OBJECT),
+ Variant.of(EMPTY_METADATA, EMPTY_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_NESTED_ARRAY),
+ Variant.of(TEST_METADATA, TEST_OBJECT_IN_ARRAY),
Review Comment:
Hi @rdblue . Friendly reminder: I also noticed the lack of array support in
`ParquetVariantUtil.ParquetSchemaProducer`. However, I also observed code
redundancy in `ParquetSchemaProducer` across `TestVariantReaders` and
`ParquetVariantUtil`.
To address this, I moved the `ParquetSchemaProducer` class outside of the
`ParquetVariantUtil` class to facilitate code reuse and ease of future
modifications.
I submit a PR for this: https://github.com/apache/iceberg/pull/12916. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
