rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062716521
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##########
@@ -360,6 +371,55 @@ public void setColumnStore(ColumnWriteStore columnStore) {
}
}
+ private static class ArrayWriter implements TypedWriter {
+ private final int definitionLevel;
+ private final int repetitionLevel;
+ private final ParquetValueWriter<VariantValue> writer;
+ private final List<TripleWriter<?>> children;
+
+ protected ArrayWriter(
+ int definitionLevel, int repetitionLevel,
ParquetValueWriter<VariantValue> writer) {
+ this.definitionLevel = definitionLevel;
+ this.repetitionLevel = repetitionLevel;
+ this.writer = writer;
+ this.children = writer.columns();
+ }
+
+ @Override
+ public Set<PhysicalType> types() {
+ return Set.of(PhysicalType.ARRAY);
+ }
+
+ @Override
+ public void write(int parentRepetition, VariantValue value) {
Review Comment:
This looks correct to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
