rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2067406237
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##########
@@ -83,6 +92,45 @@ public class TestVariantWriters {
(VariantObject) Variants.value(TEST_METADATA, SIMILAR_OBJECT_BUFFER);
private static final VariantObject EMPTY_OBJECT =
(VariantObject) Variants.value(TEST_METADATA, EMPTY_OBJECT_BUFFER);
+ private static final VariantObject ARRAY_IN_OBJECT =
+ (VariantObject) Variants.value(TEST_METADATA, ARRAY_IN_OBJECT_BUFFER);
+
+ private static final ByteBuffer EMPTY_ARRAY_BUFFER =
VariantTestUtil.createArray();
+ private static final ByteBuffer TEST_ARRAY_BUFFER =
+ VariantTestUtil.createArray(Variants.of("iceberg"),
Variants.of("string"));
+ private static final ByteBuffer MIXED_TYPE_ARRAY_BUFFER =
+ VariantTestUtil.createArray(Variants.of("iceberg"),
Variants.of("string"), Variants.of(34));
+ private static final ByteBuffer NESTED_ARRAY_BUFFER =
+ VariantTestUtil.createArray(
+ array(Variants.of("string"), Variants.of("iceberg")),
+ array(Variants.of("string"), Variants.of("iceberg")));
Review Comment:
Can you use different string values for the second array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
