aihuaxu commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2064838380
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##########
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADATA, EMPTY_OBJECT),
Variant.of(TEST_METADATA, TEST_OBJECT),
Variant.of(TEST_METADATA, SIMILAR_OBJECT),
+ Variant.of(TEST_METADATA, ARRAY_IN_OBJECT),
+ Variant.of(EMPTY_METADATA, EMPTY_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_ARRAY),
+ Variant.of(EMPTY_METADATA, TEST_NESTED_ARRAY),
+ Variant.of(TEST_METADATA, TEST_OBJECT_IN_ARRAY),
Review Comment:
Sorry that I was making the changes in TestVariantWriter before
ParquetSchemaProducer was refactored and rebase lost that change.
I was using the most common type rather than requiring the unique type
across all the array element since that is more closer to what engines will do.
And we will the cases that some elements are shredded while some are not. Let
me know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
