rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2061126510
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##########
@@ -360,6 +381,92 @@ public void setColumnStore(ColumnWriteStore columnStore) {
}
}
+ private static class ArrayValueWriter implements
ParquetValueWriter<VariantValue> {
+ private final int valueDefinitionLevel;
+ private final ParquetValueWriter<VariantValue> valueWriter;
+ private final int typedDefinitionLevel;
+ private final ArrayWriter typedWriter;
+ private final List<TripleWriter<?>> children;
+
+ private ArrayValueWriter(
Review Comment:
Can't this be replaced with `ShreddedVariantWriter`? It looks nearly
identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
