rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2061123548


##########
api/src/main/java/org/apache/iceberg/variants/VariantArray.java:
##########
@@ -20,6 +20,25 @@
 
 /** An variant array value. */
 public interface VariantArray extends VariantValue {
+  static String asString(VariantArray arr) {

Review Comment:
   I'd prefer to have the `toString` implementation at the end of the file like 
the other interfaces. When people read this file, it is most likely that they 
are interested in the methods of the interface, not the `toString` helper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to