Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1980659522
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +562,123 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return of("");
+ }
+
+ public static GeometryType of(String crs) {
+ return new GeometryType(crs == null ? "" : crs);
+ }
+
+ @Override
+ public TypeID typeId() {
+ return TypeID.GEOMETRY;
+ }
+
+ public String crs() {
+ return crs;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ } else if (!(o instanceof GeometryType)) {
+ return false;
+ }
+
+ GeometryType that = (GeometryType) o;
+ return crs.equals(that.crs);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(GeometryType.class, crs);
+ }
+
+ @Override
+ public String toString() {
+ return String.format("geometry(%s)", crs);
+ }
+ }
+
+ public static class GeographyType extends PrimitiveType {
+
+ public static final Geography.EdgeInterpolationAlgorithm DEFAULT_ALGORITHM
=
+ Geography.EdgeInterpolationAlgorithm.SPHERICAL;
+
+ private final String crs;
+ private final Geography.EdgeInterpolationAlgorithm algorithm;
+
+ private GeographyType(String crs, Geography.EdgeInterpolationAlgorithm
algorithm) {
+ this.crs = crs;
+ this.algorithm = algorithm;
+ }
+
+ public static GeographyType get() {
+ return of("");
+ }
+
+ public static GeographyType of(String crs) {
+ return of(crs, DEFAULT_ALGORITHM);
Review Comment:
Fixed. The algorithm field is null when no algorithm is specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
