szehon-ho commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1980148439


##########
build.gradle:
##########
@@ -292,6 +292,7 @@ project(':iceberg-api') {
 
   dependencies {
     implementation project(path: ':iceberg-bundled-guava', configuration: 
'shadow')
+    api libs.jts.core

Review Comment:
   I am not comfortable leaking the JTS API from Iceberg API, as this forces 
all the consumer to now depend on JTS.  Can we instead encapsulate this dep in 
iceberg-core?  Going to check with other Iceberg PMC's on this.
   
   At very least this should be implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to