Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1980662689
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -535,6 +535,8 @@ private static int estimateSize(Type type) {
return ((Types.FixedType) type).length();
case BINARY:
case VARIANT:
+ case GEOMETRY:
+ case GEOGRAPHY:
Review Comment:
We cannot give an accurate estimation without statistics of the data, so
I've simply reused the number for BINARY and VARIANT.
80 is roughly size of a polygon or linestring with 4 coordinates, which
denotes a box. This is larger for a dataset full of points and smaller for
datasets containing complex shapes, but I think it is a reasonable guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
