Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1978954363
##########
api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java:
##########
@@ -88,11 +91,64 @@ public boolean test(T value) {
return String.valueOf(value).startsWith((String) literal.value());
case NOT_STARTS_WITH:
return !String.valueOf(value).startsWith((String) literal.value());
+ case ST_INTERSECTS:
Review Comment:
Predicates and pruning were removed from this PR.
##########
api/src/main/java/org/apache/iceberg/Geography.java:
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import java.io.Serializable;
+import java.util.Locale;
+import java.util.Objects;
+import org.locationtech.jts.geom.Geometry;
+
+/**
+ * Geospatial features from OGC – Simple feature access. The geometry is on a
spherical or
+ * ellipsoidal surface. An edge-interpolation algorithm is used to evaluate
spatial predicates.
+ */
+public class Geography implements Comparable<Geography>, Serializable {
+
+ /** The algorithm for interpolating edges. */
+ public enum EdgeInterpolationAlgorithm {
+ /** Edges are interpolated as geodesics on a sphere. */
+ SPHERICAL("spherical"),
+ /** See <a
href="https://en.wikipedia.org/wiki/Vincenty%27s_formulae";>Vincenty's
formulae</a> */
+ VINCENTY("vincenty"),
+ /**
+ * Thomas, Paul D. Spheroidal geodesics, reference systems, & local
geometry. US Naval
+ * Oceanographic Office, 1970.
+ */
+ THOMAS("thomas"),
+ /**
+ * Thomas, Paul D. Mathematical models for navigation systems. US Naval
Oceanographic Office,
+ * 1965.
+ */
+ ANDOYER("andoyer"),
+ /**
+ * <a
href="https://link.springer.com/content/pdf/10.1007/s00190-012-0578-z.pdf";>Karney,
Charles
+ * FF. "Algorithms for geodesics." Journal of Geodesy 87 (2013): 43-55
</a>, and <a
+ * href="https://geographiclib.sourceforge.io/";>GeographicLib</a>.
+ */
+ KARNEY("karney");
+
+ private final String value;
+
+ EdgeInterpolationAlgorithm(String value) {
+ this.value = value;
+ }
+
+ public String value() {
+ return value;
+ }
+
+ public static EdgeInterpolationAlgorithm fromName(String algorithmName) {
+ try {
+ return
EdgeInterpolationAlgorithm.valueOf(algorithmName.toUpperCase(Locale.ENGLISH));
+ } catch (IllegalArgumentException e) {
+ throw new IllegalArgumentException(
+ String.format("Invalid edge interpolation algorithm name: %s",
algorithmName), e);
+ }
+ }
+ }
+
+ private final Geometry geometry;
+
+ public Geography(Geometry geometry) {
Review Comment:
We define Geography this way to reuse the data structures of coordinates and
geospatial objects (Points, LineString, etc.), as well as WKB/WKT functions
provided by JTS. Geography does not interoperate with Geometry, they are
different classes but have the same data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
