szehon-ho commented on code in PR #12346: URL: https://github.com/apache/iceberg/pull/12346#discussion_r1972285492
########## api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java: ########## @@ -88,11 +91,64 @@ public boolean test(T value) { return String.valueOf(value).startsWith((String) literal.value()); case NOT_STARTS_WITH: return !String.valueOf(value).startsWith((String) literal.value()); + case ST_INTERSECTS: Review Comment: Lets split out predicate pruning support. I feel 80% of the changes is to support those, let's focus in this pr to get the API right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org