Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1981048435
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -535,6 +535,8 @@ private static int estimateSize(Type type) {
return ((Types.FixedType) type).length();
case BINARY:
case VARIANT:
+ case GEOMETRY:
+ case GEOGRAPHY:
Review Comment:
I've added reasons why we use 80 (even though the choice was made randomly
like https://github.com/apache/iceberg/pull/11324/files#r1821277533) and avoid
falling back into the same case as BINARY and VARIANT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
