Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1980666883
##########
api/src/main/java/org/apache/iceberg/expressions/Literal.java:
##########
@@ -71,6 +73,14 @@ static Literal<BigDecimal> of(BigDecimal value) {
return new Literals.DecimalLiteral(value);
}
+ static Literal<Geometry> of(Geometry value) {
+ return new Literals.GeometryLiteral(value);
+ }
+
+ static Literal<Geography> of(Geography value) {
Review Comment:
I'll remove `GeometryLiteral` ad `GeographyLiteral`. The iceberg expressions
should only work with bounding boxes, so there's no need to involve
full-fledged Geometry and Geography objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
