aokolnychyi commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1802175172
########## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ########## @@ -154,6 +164,12 @@ void caseSensitive(boolean newCaseSensitive) { void delete(F file) { Preconditions.checkNotNull(file, "Cannot delete file: null"); invalidateFilteredCache(); + if (file.manifestLocation() == null) { + this.allDeletesReferenceManifests = false; + } else { + manifestsReferencedForDeletes.add(file.manifestLocation()); + } + Review Comment: Minor: Let's either add an empty line before `if` or remove this one for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org