amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1802091837
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -163,6 +163,12 @@ protected void validate(TableMetadata base, Snapshot
parent) {
}
}
+ @Override
+ protected boolean useReferencedManifestsWhenFiltering(Snapshot parent) {
+ return parent == null
+ || (startingSnapshotId != null && startingSnapshotId ==
parent.snapshotId());
Review Comment:
Not every implementation of `MergingSnapshotProducer` has a concept of a
`startingSnapshot` to begin validation from, and overwrite and row delta are
the 2 cases where we do have that. Although I will double check to make sure
we're not being needlessly restrictive in the default implementation which just
returns `false` for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
