aokolnychyi commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1802158297
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -163,6 +163,12 @@ protected void validate(TableMetadata base, Snapshot
parent) {
}
}
+ @Override
+ protected boolean useReferencedManifestsWhenFiltering(Snapshot parent) {
Review Comment:
Would something like this be easier to read? Yet to check if that's what we
want.
```
@Override
protected boolean useReferencedManifestsWhenFiltering(Snapshot parent) {
Long parentSnapshotId = parent != null ? parent.snapshotId() : null;
return Objects.equals(startingSnapshotId, parentSnapshotId);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
