aokolnychyi commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1802167002
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -163,6 +163,12 @@ protected void validate(TableMetadata base, Snapshot
parent) {
}
}
+ @Override
+ protected boolean useReferencedManifestsWhenFiltering(Snapshot parent) {
+ return parent == null
+ || (startingSnapshotId != null && startingSnapshotId ==
parent.snapshotId());
Review Comment:
I'd say we should be very careful with enabling this. We can only do this if
the set of manifests that was used for reading didn't change and the operation
is compatible. For instance, cherry-picks are not safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
