amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1801716441
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -829,6 +833,11 @@ protected Map<String, String> summary() {
@Override
public List<ManifestFile> apply(TableMetadata base, Snapshot snapshot) {
+ if (useReferencedManifestsWhenFiltering(snapshot)) {
Review Comment:
This needs to be set on every apply attempt, so I think
`useReferencedManifests` should take in a boolean which is the value provided
from the merging snapshot producer impl. Will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
