aokolnychyi commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1802177142
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -77,9 +78,12 @@ public String partition() {
private boolean failMissingDeletePaths = false;
private int duplicateDeleteCount = 0;
private boolean caseSensitive = true;
+ private boolean allDeletesReferenceManifests = true;
+ private boolean useReferencedManifests = false;
// cache filtered manifests to avoid extra work when commits fail.
private final Map<ManifestFile, ManifestFile> filteredManifests =
Maps.newConcurrentMap();
+ private final Set<String> manifestsReferencedForDeletes = Sets.newHashSet();
Review Comment:
We already have these two vars are that are closely related.
```
private final PartitionSet deleteFilePartitions;
private final Set<F> deleteFiles = newFileSet();
```
I would personally call this `deleteFileManifests` and co-locate them for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
