amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1805055837
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -77,9 +78,12 @@ public String partition() {
private boolean failMissingDeletePaths = false;
private int duplicateDeleteCount = 0;
private boolean caseSensitive = true;
+ private boolean allDeletesReferenceManifests = true;
+ private boolean useReferencedManifests = false;
// cache filtered manifests to avoid extra work when commits fail.
private final Map<ManifestFile, ManifestFile> filteredManifests =
Maps.newConcurrentMap();
+ private final Set<String> manifestsReferencedForDeletes = Sets.newHashSet();
Review Comment:
I co-located the fields, I'm still not sure I agree with the name
`deleteFileManifests` because it's more than just delete file manifests that
will be stored in the set; it can technically also be data file manifests as
well. That's why I think `manifestsWithDeletedFiles` is a more accurate name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
