fuatbasik commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1743477834
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -106,7 +109,7 @@ public static String testMultiRegionAccessPointAlias() {
return System.getenv("AWS_TEST_MULTI_REGION_ACCESS_POINT_ALIAS");
}
- public static void cleanS3Bucket(S3Client s3, String bucketName, String
prefix) {
+ public static void cleanS3GeneralBucket(S3Client s3, String bucketName,
String prefix) {
Review Comment:
nit: should we keep this method name as is and change the S3 Express bucket
name as S3 Express bucket as `Directory Bucket` to be aligned with public AWS
documentation
https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-express-differences.html
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -127,6 +130,20 @@ public static void cleanS3Bucket(S3Client s3, String
bucketName, String prefix)
}
}
+ /**
+ * Method used to clean up S3 express bucket which doesn't care about
versions
+ * @param s3FileIO an instance of s3FileIO to be used to list/delete objects
+ * @param bucketName name of the bucket
+ * @param prefix the path prefix we want to remove
+ */
+ public static void cleanS3ExpressBucket(S3FileIO s3FileIO, String prefix,
String bucketName) {
Review Comment:
please see my previous comment about method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
