stubz151 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1766980326
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -298,8 +298,13 @@ private List<String> deleteBatch(String bucket,
Collection<String> keysToDelete)
@Override
public Iterable<FileInfo> listPrefix(String prefix) {
S3URI s3uri = new S3URI(prefix,
s3FileIOProperties.bucketToAccessPointMapping());
+ String suffix = "";
+ if (S3Express.checkIfS3Express(s3uri.bucket()) && !prefix.endsWith("/")) {
+ suffix = "/";
+ }
+
ListObjectsV2Request request =
-
ListObjectsV2Request.builder().bucket(s3uri.bucket()).prefix(s3uri.key()).build();
+
ListObjectsV2Request.builder().bucket(s3uri.bucket()).prefix(s3uri.key() +
suffix).build();
Review Comment:
It throws an unsupported exception.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html#API_ListObjectsV2_RequestSyntax
under prefix you can see the docs on how it's not supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
