jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1764150636
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -298,8 +298,13 @@ private List<String> deleteBatch(String bucket,
Collection<String> keysToDelete)
@Override
public Iterable<FileInfo> listPrefix(String prefix) {
S3URI s3uri = new S3URI(prefix,
s3FileIOProperties.bucketToAccessPointMapping());
+ String suffix = "";
+ if (S3Express.checkIfS3Express(s3uri.bucket()) && !prefix.endsWith("/")) {
+ suffix = "/";
+ }
+
ListObjectsV2Request request =
-
ListObjectsV2Request.builder().bucket(s3uri.bucket()).prefix(s3uri.key()).build();
+
ListObjectsV2Request.builder().bucket(s3uri.bucket()).prefix(s3uri.key() +
suffix).build();
Review Comment:
help me understand, what would be the behavior if I list objects without a
`/` in a directory bucket? would it fail, or list assuming it is a directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
