steveloughran commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1773779337
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -194,9 +194,9 @@ public void testNewInputStreamWithAccessPoint() throws
Exception {
}
@Test
- @DisabledIf(value = "checkIfS3ExpressHelper",
- disabledReason = "S3 Express doesn’t support Access Points
currently")
public void testNewInputStreamWithCrossRegionAccessPoint() throws Exception {
+ // S3 Express doesn’t support Access Points currently
+ assumeFalse(S3FileIO.checkIfS3Express(bucketName));
Review Comment:
1. assertJ AssertJ has some really good assumption statements along with its
assertions.
2. there's enough commonality that something like
```
requireAccessPointSupport()
```
and use everywhere. That would even work if the test. suite evolved to
actually the executable against other S3 implementation and some configuration
option was added to especially disable AWS-only tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
