stubz151 commented on PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#issuecomment-2324759204
> > I can add the backslash to the ListPrefix request. Do we want to do it
for all s3 buckets(general + directory) this will be a breaking change, or
would we prefer to add it in like I have done with the tests?
>
> If you don't do it in production then things which omit to pass it down
will break. And i'm confident that nothing is passing down a path like
>
> listObjects("path/p1") expecting it to find `path/p1/*` and other matches
like `path/p1Filename`, else HadoopFileIO list prefix would be failing and
people would have noticed.
Have added it for express, let me know what you think :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
