jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1764135625
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -589,4 +623,13 @@ private void createRandomObjects(String objectPrefix, int
count) {
builder -> builder.bucket(s3URI.bucket()).key(s3URI.key()
+ i).build(),
RequestBody.empty()));
}
+
+
+ /**
+ * A local S3 Express check helper that helps it be used in the annotations
for the disabled tests
+ * @return true if S3 Express, false otherwise
+ */
+ private static boolean checkIfS3ExpressHelper() {
+ return S3Express.checkIfS3Express(AwsIntegTestUtil.testBucketName());
Review Comment:
I think we could potentially parameterize the tests, and use `Assume`
capability to skip some tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
