stubz151 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1734788413
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/S3TestUtil.java:
##########
@@ -29,4 +33,12 @@ public static String getBucketFromUri(String s3Uri) {
public static String getKeyFromUri(String s3Uri) {
return new S3URI(s3Uri).key();
}
+
+ /**
+ * A helper method that checks if the s3 bucket is a general purpose bucket
or directory bucket based on the suffix.
+ * @return true if it is an s3 express bucket otherwise false.
+ */
+ public static boolean checkIfS3Express() {
+ return AwsIntegTestUtil.testBucketName().endsWith(EXPRESS_BUCKET_SUFFIX);
Review Comment:
Don't think this proposed solution is sufficient and this doesn't cover
proxy environments and other regions like gov cloud and other AWS classified
regions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
