jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1764131672
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -106,7 +109,7 @@ public static String testMultiRegionAccessPointAlias() {
return System.getenv("AWS_TEST_MULTI_REGION_ACCESS_POINT_ALIAS");
}
- public static void cleanS3Bucket(S3Client s3, String bucketName, String
prefix) {
+ public static void cleanS3GeneralBucket(S3Client s3, String bucketName,
String prefix) {
Review Comment:
What do you call the existing buckets then? Looks like it is called "general
purpose bucket"? I am okay renaming this method to
`cleanS3GeneralPurposeBucket` but I agree the other method should be
`cleanS3DirectoryBucket`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
