klsince opened a new pull request, #14094: URL: https://github.com/apache/pinot/pull/14094
This PR refines some checks on upsert TTL: 1) _largestSeenComparisonValue can be negative so check it against special value Double.MIN_VALUE instead of 0; 2) allow to disable the logic to skip adding segments outside TTL, in case one wants to add segments even if they are out of TTL. This may be needed when if one uploads segments to upsert table directly, but they are out of TTL. If they are skipped, then all their docs are treated as valid, and if so, the table data is not right unless docs in those uploaded segments are supposed to be all valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
