tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1777692615
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -435,6 +434,16 @@ public void addSegment(ImmutableSegment segment) {
}
}
+ protected boolean shouldSkipAddSegmentOutOfTTL() {
+ return true;
+ }
+
+ private boolean isOutOfMetadataTTL(IndexSegment segment) {
+ Number maxComparisonValue =
Review Comment:
we can check before reading segment metadata if
`_largestSeenComparisonValue.get() != LARGEST_COMPARISON_VALUE_NOT_SET` else
return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
