tibrewalpratik17 commented on code in PR #14094:
URL: https://github.com/apache/pinot/pull/14094#discussion_r1777721197
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -88,6 +88,8 @@
@ThreadSafe
public abstract class BasePartitionUpsertMetadataManager implements
PartitionUpsertMetadataManager {
protected static final long OUT_OF_ORDER_EVENT_MIN_REPORT_INTERVAL_NS =
TimeUnit.MINUTES.toNanos(1);
+ // The special value to indicate the largest comparison value is not set yet.
+ private static final double LARGEST_COMPARISON_VALUE_NOT_SET =
Double.MIN_VALUE;
Review Comment:
if the idea is to support negative comparison value then i think you might
want to use `NEGATIVE_INFINITY` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
