On 2016/03/15 11:29, Bryan C. Everly wrote:
> Stuart,
>
> Thanks so much for the feedback. I have incorporated all of the
> suggested changes in the attached tarball. Can I get an ok on this and
> have someone please commit on my behalf?
On 2016/03/16 08:41, Bryan C. Everly wrote:
> Stuart,
>
Thanks Stuart!
Thanks,
Bryan
On Wed, Mar 16, 2016 at 8:44 AM, Stuart Henderson
wrote:
> On 2016/03/15 11:29, Bryan C. Everly wrote:
> > Stuart,
> >
> > Thanks so much for the feedback. I have incorporated all of the
> > suggested changes in the attached tarball. Can I get an ok on this and
>
A couple of minor things, in the script in files/:
+LIQUIBASE_HOME=${LOCALBASE}/share/java/classes/liquibase
LOCALBASE is "where other ports have already been installed", the script
should use TRUEPREFIX instead i.e. "Base directory for the current port
installation".
And in README,
--classpath
Stuart,
Thanks for getting back to me!
I've attached a new tarball that contains the suggested fixes. What do you
think?
Thanks,
Bryan
On Thu, Mar 17, 2016 at 6:23 PM, Stuart Henderson
wrote:
> A couple of minor things, in the script in files/:
>
> +LIQUIBASE_HOME=${LOCALBASE}/share/java/cl
Adam,
Awesome. Thank you so much for the help.
Thanks,
Bryan
On Fri, Mar 18, 2016 at 11:57 AM, Adam Wolk wrote:
> On Thu, 17 Mar 2016 23:20:07 +
> Stuart Henderson wrote:
>
> > On 2016/03/17 19:05, Bryan C. Everly wrote:
> > > Stuart,
> > >
> > > Thanks for getting back to me!
> > >
> >
On 2016/03/17 19:05, Bryan C. Everly wrote:
> Stuart,
>
> Thanks for getting back to me!
>
> I've attached a new tarball that contains the suggested fixes. What do you
> think?
OK with me. (Forgot to mention I'd probably also just go with
a longer line for MASTER_SITES rather than split it into
On 2016/03/17 19:24, Bryan C. Everly wrote:
> Stuart,
>
> No objections from me. I was just trying to stick to the 72 character line
> length limit and without splitting it, it took it over that.
There's no 72 character line length limit in ports Makefiles. There's
a preference for <=80 columns
Stuart,
No objections from me. I was just trying to stick to the 72 character line
length limit and without splitting it, it took it over that.
Anyone else willing to give me a second "OK" on this and do the commit on
my behalf?
(just for the curious, I'm working up some ports to suggest that w
On Thu, 17 Mar 2016 23:20:07 +
Stuart Henderson wrote:
> On 2016/03/17 19:05, Bryan C. Everly wrote:
> > Stuart,
> >
> > Thanks for getting back to me!
> >
> > I've attached a new tarball that contains the suggested fixes.
> > What do you think?
>
> OK with me. (Forgot to mention I'd pro
Stuart,
Thanks so much for the feedback. I have incorporated all of the suggested
changes in the attached tarball. Can I get an ok on this and have someone
please commit on my behalf?
Thanks,
Bryan
On Sun, Mar 13, 2016 at 5:24 PM, Stuart Henderson
wrote:
> | COMMENT = Manage s
Adam,
I created a simple database in PostgreSQL called "foo" and used the
attached script and change log to add a new table to it.
You will need to install PostgreSQL and it's JDBC driver.
Please let me know if this works for you!
Thanks,
Bryan
On Sun, Mar 13, 2016 at 2:45 PM, Adam Wolk wrot
| COMMENT = Manage sql database schemas via config files
please lowercase M (and I'd uppercase SQL..)
| MODJAVA_VER = 1.7
is 1.7 a hard dep? 1.7+ is better if it works with 1.8.
| +LIQUIBASE_HOME=/usr/local/share/java/classes/liquibase
/usr/local -> ${LOCALBASE}
| See
Ports@
I have worked with Adam to get this port to a good place. If someone can
give us OKs on this and then commit it on my behalf, I would very much
appreciate it.
Thanks Adam and Ian for your feedback and mentoring!
Bryan
On Sun, Mar 13, 2016 at 11:56 AM, Bryan C. Everly
wrote:
> Hi ports
Adam,
Happy to work on snakeyaml and possibly the other popular JDBC drivers. I
use PostgreSQL almost exclusively so I hadn't had the opportunity to look
for any of the others but you are right, it appears we don't have any other
ones in the ports tree.
Here is an updated tarball with the pkg-re
It's an interesting suggestion. However, the normal users of this tool are
used to supplying the driver JAR file at the command line so it would be
changing the expected behaviour of the application.
Does that make sense?
Thanks,
Bryan
On Sun, Mar 13, 2016 at 3:30 PM, Ian Darwin wrote:
>
>
>
On Sun, 13 Mar 2016 15:02:11 -0400
"Bryan C. Everly" wrote:
> Adam,
>
> I created a simple database in PostgreSQL called "foo" and used the
> attached script and change log to add a new table to it.
>
> You will need to install PostgreSQL and it's JDBC driver.
>
> Please let me know if this wo
On 2016-03-13 2:45 PM, Adam Wolk wrote:
I like the changes and the port now 'works' on my side.
First impressions are not great:
$ liquibase --changeLogFile=1.json --url="" updateSQL
Unexpected error running Liquibase: java.lang.RuntimeException: Cannot find
database driver: Driver class w
On Sun, 13 Mar 2016 14:00:41 -0400
"Bryan C. Everly" wrote:
> Adam,
>
> Thanks for the feedback!
>
> I've attached a new tarball with some of the changes you recommend.
> Unfortunately I am not upstream (this is an open source project my
> company uses) so I have to have the patches in place.
>
Adam,
Thanks for the feedback!
I've attached a new tarball with some of the changes you recommend.
Unfortunately I am not upstream (this is an open source project my company
uses) so I have to have the patches in place.
Also, the WRKDIST = ${WRKDIR} part is needed because upstream named their
DI
On Sun, 13 Mar 2016 11:56:43 -0400
"Bryan C. Everly" wrote:
> Hi ports@
>
> Attached is my port of the most recent version of liquibase (
> http://liquibase.org).
>
> Liquibase is a tool that developers use to maintain the schema of
> databases (similar in concept to rake db:migrate from rails)
Hi ports@
Attached is my port of the most recent version of liquibase (
http://liquibase.org).
Liquibase is a tool that developers use to maintain the schema of databases
(similar in concept to rake db:migrate from rails). The tool is capable of
using cross-database change scripts that can then
21 matches
Mail list logo
