Adam, Thanks for the feedback!
I've attached a new tarball with some of the changes you recommend.
Unfortunately I am not upstream (this is an open source project my company
uses) so I have to have the patches in place.
Also, the WRKDIST = ${WRKDIR} part is needed because upstream named their
DISTNAME the way they did (with a -bin suffix on it). Since I have to
declare DISTNAME that way to get it to download, if I didn't remap WRKDIST,
then it would be looking for a directory with a -bin suffix on it in pobj.
I am working with upstream to get them to take my manpage and if they do,
I'll remove it from the port in my maintenance for their next release.
Sorry about the root directory tarball. I forgot the protocol on that
one. :-)
Given all of that, what do you think of the new tarball with the changes?
Thanks,
Bryan
On Sun, Mar 13, 2016 at 12:28 PM, Adam Wolk <adam.w...@tintagel.pl> wrote:
> On Sun, 13 Mar 2016 11:56:43 -0400
> "Bryan C. Everly" <br...@bceassociates.com> wrote:
>
> > Hi ports@
> >
> > Attached is my port of the most recent version of liquibase (
> > http://liquibase.org).
> >
> > Liquibase is a tool that developers use to maintain the schema of
> > databases (similar in concept to rake db:migrate from rails). The
> > tool is capable of using cross-database change scripts that can then
> > be applied to multiple database platforms (PostgreSQL, Oracle, mySQL,
> > etc.)
> >
> > I'm trying to get my company's complete development toolchain
> > available as a port/package so I can start luring the other
> > developers over to OpenBSD.
> >
> > Could someone please look this over, give me any necessary feedback
> > and (if it looks ok), commit this on my behalf?
> >
> > Thanks,
> > Bryan
>
> COMMENT = tool to manage sql database schemas via config
> files
>
> I think
> COMMENT = manage sql database schemas via config files
>
> would be enough.
>
> WRKDIST = ${WRKDIR}
>
> This WRKDIST change seems not needed.
>
>
> EXTRACT_ONLY = ${DISTNAME}.tar.gz
>
> Not needed? You only have a single distfile.
>
> $
> portcheck 1 line(s) longer than 80 chars in Makefile
> Makefile does not have $OpenBSD$ RCS tag at the top
> databases/liquibase
>
>
> Your patch changes the upstream shell interpreter from /usr/bin/env
> bash to /bin/sh. Sounds like something that could be taken by upstream
> (which is you if I read you correctly ;)). The LIQUIBASE_HOME addition
> also looks like something that could be handled in the script itself?
>
>
> cp ${FILESDIR}/liquibase.1 ${PREFIX}/man/man1
> cp -r ${WRKDIR}/liquibase.jar
> ${PREFIX}/share/java/classes/liquibase cp -r
> ${WRKDIR}/liquibase ${PREFIX}/bin
>
> The cp commands should be an ${INSTALL_DATA}.
>
> .Dt LIQUIBASE section
>
> ^ is there a section number missing in your man page? Additionally can
> the mangpage be shipped upstream?
>
> When I try to run:
> $
> liquibase /usr/local/bin/liquibase[58]: java: not found
>
> I do have java installed and the javaPathHelper. Minecraft manages to
> run fine, maybe check how it does things in it's script?
>
> Stopping here for now. You might also want to tar cvf port.tar port/
> then gzip it. I don't like ports extracting into full
> usr/ports/category/name paths but that's just only my preference.
>
> Regards,
> Adam
>
liquibase.tgz
Description: GNU Zip compressed data
