On Sun, 13 Mar 2016 14:00:41 -0400
"Bryan C. Everly" <br...@bceassociates.com> wrote:

> Adam,
> 
> Thanks for the feedback!
> 
> I've attached a new tarball with some of the changes you recommend.
> Unfortunately I am not upstream (this is an open source project my
> company uses) so I have to have the patches in place.
> 

That's ok. Still you can pester them to take the changes upstream ;)

> Also, the WRKDIST = ${WRKDIR} part is needed because upstream named
> their DISTNAME the way they did (with a -bin suffix on it).  Since I
> have to declare DISTNAME that way to get it to download, if I didn't
> remap WRKDIST, then it would be looking for a directory with a -bin
> suffix on it in pobj.
> 
> I am working with upstream to get them to take my manpage and if they
> do, I'll remove it from the port in my maintenance for their next
> release.
> 

Great and thanks for fixing the section number.

> Sorry about the root directory tarball.  I forgot the protocol on that
> one.  :-)
> 

That's ok. 

> Given all of that, what do you think of the new tarball with the
> changes?
> 


I like the changes and the port now 'works' on my side.

First impressions are not great:
$ liquibase --changeLogFile=1.json --url="" updateSQL 
Unexpected error running Liquibase: java.lang.RuntimeException: Cannot find 
database driver: Driver class was not specified and could not be determined 
from the url ()

$ liquibase --changeLogFile=1.json 
--url="jdbc:mysql://localhost/dbname?useUnicode=true&characterEncoding=UTF-8" 
updateSQL
Unexpected error running Liquibase: java.lang.RuntimeException: Cannot find 
database driver: com.mysql.jdbc.Driver

1.json is the content from 
http://www.liquibase.org/documentation/json_format.html

Is there a way to test this port in a simple way?

Regards,
Adam

Reply via email to