On Sun, 13 Mar 2016 11:56:43 -0400 "Bryan C. Everly" <br...@bceassociates.com> wrote:
> Hi ports@ > > Attached is my port of the most recent version of liquibase ( > http://liquibase.org). > > Liquibase is a tool that developers use to maintain the schema of > databases (similar in concept to rake db:migrate from rails). The > tool is capable of using cross-database change scripts that can then > be applied to multiple database platforms (PostgreSQL, Oracle, mySQL, > etc.) > > I'm trying to get my company's complete development toolchain > available as a port/package so I can start luring the other > developers over to OpenBSD. > > Could someone please look this over, give me any necessary feedback > and (if it looks ok), commit this on my behalf? > > Thanks, > Bryan COMMENT = tool to manage sql database schemas via config files I think COMMENT = manage sql database schemas via config files would be enough. WRKDIST = ${WRKDIR} This WRKDIST change seems not needed. EXTRACT_ONLY = ${DISTNAME}.tar.gz Not needed? You only have a single distfile. $ portcheck 1 line(s) longer than 80 chars in Makefile Makefile does not have $OpenBSD$ RCS tag at the top databases/liquibase Your patch changes the upstream shell interpreter from /usr/bin/env bash to /bin/sh. Sounds like something that could be taken by upstream (which is you if I read you correctly ;)). The LIQUIBASE_HOME addition also looks like something that could be handled in the script itself? cp ${FILESDIR}/liquibase.1 ${PREFIX}/man/man1 cp -r ${WRKDIR}/liquibase.jar ${PREFIX}/share/java/classes/liquibase cp -r ${WRKDIR}/liquibase ${PREFIX}/bin The cp commands should be an ${INSTALL_DATA}. .Dt LIQUIBASE section ^ is there a section number missing in your man page? Additionally can the mangpage be shipped upstream? When I try to run: $ liquibase /usr/local/bin/liquibase[58]: java: not found I do have java installed and the javaPathHelper. Minecraft manages to run fine, maybe check how it does things in it's script? Stopping here for now. You might also want to tar cvf port.tar port/ then gzip it. I don't like ports extracting into full usr/ports/category/name paths but that's just only my preference. Regards, Adam
