On Thu, 17 Mar 2016 23:20:07 +0000
Stuart Henderson <s...@spacehopper.org> wrote:
> On 2016/03/17 19:05, Bryan C. Everly wrote:
> > Stuart,
> >
> > Thanks for getting back to me!
> >
> > I've attached a new tarball that contains the suggested fixes.
> > What do you think?
>
> OK with me. (Forgot to mention I'd probably also just go with
> a longer line for MASTER_SITES rather than split it into two
> variables, BASE_URL caused a bit of extra head-scratching
> because it sounds like a name that might be used in ports
> infrastructure - whoever commits could just change that if
> you agree, I don't think it needs a new tgz).
>
Thanks, just committed the port. Changed the MASTER_SITES like you
requested and additionally compacted a line break in pkg/README (the
one which had trailing whitespace).
>
> >
> > Thanks,
> > Bryan
> >
> > On Thu, Mar 17, 2016 at 6:23 PM, Stuart Henderson
> > <s...@spacehopper.org> wrote:
> >
> > > A couple of minor things, in the script in files/:
> > >
> > > +LIQUIBASE_HOME=${LOCALBASE}/share/java/classes/liquibase
> > >
> > > LOCALBASE is "where other ports have already been installed", the
> > > script should use TRUEPREFIX instead i.e. "Base directory for the
> > > current port installation".
> > >
> > > And in README,
> > >
> > > --classpath=/usr/local/share/postgresql/java/postgresql.jar
> > >
> > > The hardcoded /usr/local here should be ${LOCALBASE}.
> > >
> > > Rest is ok.
> > >
> > >
>
>
