[Differential] [Commented On] D3923: Make AppstreamQt optional

hein added a comment. I'm in principle OK with this patch, but also don't mind the change apol requested if it makes him happier since it's his code. In this context I'd like to mention that I was slightly surprised/miffed that the original change went into Kicker during my vacation with

[Differential] [Accepted] D3927: Fix CD'ing into desktop files in plasma folder view placed inside panel

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3927 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, #plasma, hein Cc: plasma-devel, lesli

[Differential] [Accepted] D3925: Remove unused #defines

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3925 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 26 lines] D3928: Sync opacity from an internal QWindow to its ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change adds support for opacity on a KWin internal QWindow. C

[Differential] [Accepted] D3922: Don't search for packagekit, we don't use it anywhere anymore

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3922 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Accepted] D3921: Remove outdated PackageKit include

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3921 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Request, 16 lines] D3927: Fix CD'ing into desktop files in plasma folder view placed inside panel

chinmoyr created this revision. chinmoyr added reviewers: hein, Plasma. chinmoyr set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When in folder view(placed in pa

[Differential] [Updated, 2,230 lines] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

davidedmundson updated this revision to Diff 9624. davidedmundson added a comment. remove debug that arc decided I had accidentally left out of my commit so added back REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3926?vs=9623&id=9624 BRANCH m

[Differential] [Request, 2,243 lines] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY libdbusmenu-qt had an awful bug in it that meant it would spawn a nested event loop when upda

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 104 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/104/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 00:41:21 + Build duration: 9 min 0 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D3923: Make AppstreamQt optional

mak added a comment. @davidedmundson What do you mean with big dependency chain? libappstream and libappstreamQt depend in total on only libxml2, libyaml, GLib and Qt5Core which pretty much any distro, especially with Plasma on it, should already have anyway. Didn't you use Neon? Or was it

[Differential] [Accepted] D3923: Make AppstreamQt optional

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I disagree that it's a big dependency chain, I agree that the feature is quite small, it's just appstream, but ok. INLINE COMMENTS > appentry.cpp:146 > { > +#ifdef APPSTREAMQT > static A

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 101 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 00:37:49 + Build duration: 5 min 39 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Request, 3 lines] D3925: Remove unused #defines

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Grepped REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabric

problems with Kirigami on iOS

Since updating to Kirigami 2.0 and Qt 5.7.1 there's a new problem that I don't quite know how to fix. It seems that Qt Quick Controls 2 requires a plugin - but I can't figure out how to provide that plugin on iOS: QQmlApplicationEngine failed to load component qrc:///qml/main.qml:333 Type DiveL

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

> On Jan. 2, 2017, 9:39 p.m., David Edmundson wrote: > > I'm a bit confused by one part: > > > > kpackagetool5 --help > > tells me: > > > > -t, --type The type of package, e.g. theme, wallpaper, > >plasmoid, dataengine, runner, > > layout-template,

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101746 --- src/plasmapkg/main.cpp (line 82)

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101745 --- I'm a bit confused by one part: kpackagetool5 --help tells

Re: FYI: New calendar project (uses C++14 and C++17).

Look ok to me. I hate Qt data models, so I'm not the best person to comment on them. As for the date stuff, you can check out the boost library (used in Eric's talk) - I guess you would have less things to reimplement yourself. Cheers, Ivan On Mon, Jan 2, 2017 at 11:21 AM, Mark Gaiser wrote: >

Re: update kirigami.pri

On Monday 02 January 2017, Dirk Hohndel wrote: > Happy New Year, > > As I am working through all the changes that I have missed in the last few > months, I noticed that the Subsurface-mobile iOS version no longer builds. > Turns out that the kirigami.pri file wasn't updated to include the > settin

update kirigami.pri

Happy New Year, As I am working through all the changes that I have missed in the last few months, I noticed that the Subsurface-mobile iOS version no longer builds. Turns out that the kirigami.pri file wasn't updated to include the settings. /D From 3afe1014faa087835ed3774b542a8bbc79b814be M

[Differential] [Updated] D3923: Make AppstreamQt optional

subdiff added a reviewer: apol. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, apol Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abet

Re: Review Request 129697: Figure out software center integration on the menus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/#review101739 --- Unfortunately, this also noticeably slows down the context m

Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/ --- Review request for Plasma and Aleix Pol Gonzalez. Bugs: 374463 http:/

Re: Review Request 129753: search and replace old hardcoded types from plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/ --- (Updated Jan. 2, 2017, 7:52 p.m.) Review request for Plasma and Aleix Pol

[Differential] [Request, 21 lines] D3923: Make AppstreamQt optional

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Normally I would just close any bug report saying a 3rd party lib should be optional, but it'

[Differential] [Closed] D3878: Use removeOne when uninstalling an InputEventFilter

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a8db96750595: Use removeOne when uninstalling an InputEventFilter (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3878?vs=9511&id=9614 REVISIO

[Differential] [Closed] D3877: Use a templated approach for InputRedirection::processFilters

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4db535db07e3: Use a templated approach for InputRedirection::processFilters (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3877?vs=9510&id=961

[Differential] [Request, 4 lines] D3922: Don't search for packagekit, we don't use it anywhere anymore

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3922 AFFECTED F

[Differential] [Request, 4 lines] D3921: Remove outdated PackageKit include

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PackageKitQt5_FOUND can never be set, it's a leftover that should be removed wtih https://ph

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/#review101738 --- unfortunately this has a significant problem: see https://bu

[Differential] [Commented On] D3878: Use removeOne when uninstalling an InputEventFilter

graesslin added inline comments. INLINE COMMENTS > mart wrote in input.cpp:1378 > i know OT, but would be possible for this not being public api for the typo > to be fixed? uh, nice spotting. Yeah will fix it. REPOSITORY R108 KWin BRANCH input-event-filter-remove-one REVISION DETAIL ht

Re: Minutes Monday Plasma Meeting

* Improved media controller a bit and some minor bugfixing there: now shows album name (or containing folder if there's none) as well as elapsed/remaining time * Optimizations in notifications and jobs * Improved support for Trash in Folder View (e.g. "Restore" option) * show scrollbar backgro

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

graesslin added a comment. In https://phabricator.kde.org/D3829#73066, @xuetianweng wrote: > In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > > > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say

[Differential] [Closed] D3915: Sync startplasma with a startkde change

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bc46f163234f: Sync startplasma with a startkde change (authored by broulik, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D39

[Differential] [Requested Changes To] D3630: [Digital Clock] Bug fixes and ui code optimization

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, pl

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. the problem for me is sizehelper having a wrong size when the state is horizontalPanelSmall if i add an huge pixelSize to sizehelper (as it was used to have), the layout problem is fixed INLINE COMMENTS > DigitalClock.qml:531 > font.italic: timeLabel.font

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. I'm afraid we're still not there: if i slowly resize the panel, for most sized is ok, but if i get it just the right size, that's what i get: F1712327: Spectacle.C23157.png REPOSITORY R120 Plasma Workspace REVISION DETAIL htt

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 506 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/506/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 16:01:39 + Build duration: 5 min 45 sec CHANGE SET Revision bccae188ffbe7f61242c88ec94ae79d

[Differential] [Closed] D3885: Minor fix for plasma folder view filename editor

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bccae188ffbe: Minor fix for plasma folder view filename editor (authored by chinmoyr). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3885?vs=9606&id=9607 R

[Differential] [Updated, 8 lines] D3885: Minor fix for plasma folder view filename editor

chinmoyr updated this revision to Diff 9606. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3885?vs=9540&id=9606 REVISION DETAIL https://phabricator.kde.org/D3885 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml EMAIL PREFERE

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

hein added inline comments. INLINE COMMENTS > broulik wrote in main.xml:78 > I don't want to change the sorting, though, but I'll have a look The sort mode would be optional. Could also be a new model column to set as sort colimn :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

broulik added inline comments. INLINE COMMENTS > hein wrote in main.xml:78 > We have KActivitiesStats to track access frequency of locations, doing this > in the TM applet is wrong. I propose you add KActivitieStats support to the > places model and add a sort mode using it. I don't want to ch

[Powerdevil] [Bug 365100] Power button ignored

https://bugs.kde.org/show_bug.cgi?id=365100 --- Comment #1 from Gordan Krešić --- Just to confirm that this issue is still reproducible on Plasma 5.8.4. Other components: OS: Kubuntu 16.10 (Plasma backported from Kubuntu Backports https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/backports) K

[Differential] [Changed Subscribers] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

anthonyfieroni added inline comments. INLINE COMMENTS > iconapplet.cpp:235 > +m_openWithActions.clear(); > +delete m_openContainingFolderAction; > +} Make it smart pointer or assign nullptr after deletion or you hit a crash below REPOSITORY R120 Plasma Workspace REVISION

[Differential] [Requested Changes To] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.xml:78 > > + > + Keeps track which of the user's 'Places' he or she prefers. A > JSON object with URL as key and an integer representing how o

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 505 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/505/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 11:35:39 + Build duration: 6 min 33 sec CHANGE SET Revision 20837d27905316ae735cc0e168f831c

Minutes Monday Plasma Meeting

Voila. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 02-01-2017 Present: Sho_, romangg, notmart, bshah, jgrulich, sebas Sho: * Got back into the "office" to "laptop won't turn on or boot", had to get a new charger from the MS Service center today /o\ * Went through cl

[Differential] [Updated] D3805: Per-activity favorites (WIP)

hein added a comment. Please make sure I get an opportunity to review this before it goes in (I just got back from vacation). And the revision it needs to be rebased against is actually -1 from me right now. Please be less in a rush to push things to Kicker without maintainer approv

[Differential] [Requested Changes To] D3910: [Kicker] Don't nuke favorites on startup

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Actually I can already say I don't like this approach - this means refresh() won't work if no favorites are set on the model. This happens to work for Kicker & co because they have fa

Re: FYI: New calendar project (uses C++14 and C++17).

On Mon, Jan 2, 2017 at 10:46 AM, Ivan Čukić wrote: > Hi Mark, > > An alternative to Niebler's range-v3 and cppitertools you might want > to try is boost.range (it is a part of the default boost package, I > don't know whether it has everything you'd need for this). > > I haven't seen where you us

[Differential] [Updated] D3910: [Kicker] Don't nuke favorites on startup

hein added a comment. Please give me some time to review this. I was looking into this regression before vacation as well and it was non-trivial, so I want to make sure this handles all the scenarios correctly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Accepted] D3893: [Folder View] Let IconItem take entire delegate width

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3893 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, hein, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, ab

[Differential] [Accepted] D3916: TaskManager: Hide tooltip after activating task

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3916 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, hein, #plasma Cc: plas

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

ivan added a comment. I'll rebase when 5.9 is released, and add - previous configured favourites transitioning mechanism - inserting a favourite on a spacified position (for dashboard) REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Accepted] D3885: Minor fix for plasma folder view filename editor

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This was actually intentional in the original patch, the author preferred to expand but not shrink, and I didn't mind. I also don't mind shrinking though, I see Roman's point here (IRC): > ‎[19:51] ‎<‎romangg

[Differential] [Request, 2 lines] D3917: AppletConfig: Use correct icon state for category icons

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QIcon::Selected should only be used when current item && active focus. TEST PLAN It now display same icon st

Re: Plasma 5.9 Release Announcement

No idea how to make it writable to all other accounts. Let's do it the old-fashioned way then: ‎https://notes.kde.org/p/plasma_5_9

[Differential] [Accepted] D3915: Sync startplasma with a startkde change

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3915 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3911: [Containment Appearance] Make sure to always load a config view

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3911 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated] D3805: Per-activity favorites (WIP)

mart added a comment. probably needs to be rebased for eventual conflicts with https://phabricator.kde.org/D3910 REVISION DETAIL https://phabricator.kde.org/D3805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, hein, mart Cc: plasma-devel, leslie

[Differential] [Accepted] D3910: [Kicker] Don't nuke favorites on startup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Request, 3 lines] D3916: TaskManager: Hide tooltip after activating task

drosca created this revision. drosca added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So that the tooltip doesn't unnecessarily cover activated window. Also under high load it can happen

[Differential] [Commented On] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

mart added a comment. if i understood correctly the code, for deskto files that points to an app shortcut those two entries would not be added, right? (that's i think how it should work) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3905 EMAIL PREFERENCE

[Differential] [Accepted] D3893: [Folder View] Let IconItem take entire delegate width

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. +100 as soon as https://phabricator.kde.org/D3892 can go in REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3893 EMAIL PREFERENCES

[Differential] [Accepted] D3878: Use removeOne when uninstalling an InputEventFilter

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. fine as the asserts guards more than one is never added INLINE COMMENTS > input.cpp:1378 > > void InputRedirection::prepandInputEventFilter(InputEventFilter *fil

[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in iconitem.cpp:325 > This makes no sense. > You can't round it to icon sizes *after* scaling, it means the shorter size > is always just wrong. > > If we do merge this patch, you want: > > m_iconPixmap.size().scaled(QSize(Unit

[Differential] [Accepted] D3877: Use a templated approach for InputRedirection::processFilters

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH input-event-filter-process-predicate REVISION DETAIL https://phabricator.kde.org/D3877 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

Re: FYI: New calendar project (uses C++14 and C++17).

Hi Mark, An alternative to Niebler's range-v3 and cppitertools you might want to try is boost.range (it is a part of the default boost package, I don't know whether it has everything you'd need for this). I haven't seen where you used struct-bindings - the code compiles fine with gcc -std=c++14.

[Differential] [Accepted] D3885: Minor fix for plasma folder view filename editor

subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land. Just a nitpick: Since you have `realHeight` as the first argument, maybe also define it as first. REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

[Differential] [Accepted] D3906: [Icon Applet] Fully re-populate when user changes Link URL

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > iconapplet.cpp:369 > +QFile::remove(m_localPath); > +setUrl(QUrl(desktopFile.readUrl())); // calls populate() itself > +} else { It look

[Differential] [Commented On] D3898: Applet: Don't delete delegates while drag is active

hein added a comment. (Just for the record: Applets like Task Manager, Folder View and Kicker-based launchers instead use a helper QObject class to instanciate QDrag and parent it to the applet itself.) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.o

[Differential] [Accepted] D3897: [Panel Containment] Explicitly bind visible on both the container and the applet

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3897 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,